3 months agomerge from default with a lot of effort ARC
Frank Dowsett <wixardy@adium.im> [Thu, 02 Feb 2012 01:33:07 -0500] rev 4643
merge from default with a lot of effort

3 months agoThese cannot be weak. ARC
Frank Dowsett <wixardy@adium.im> [Thu, 02 Feb 2012 00:40:19 -0500] rev 4642
These cannot be weak.

3 months agoBy request, switch to 10.7 to take full advantage of ARC. ARC
Frank Dowsett <wixardy@adium.im> [Thu, 02 Feb 2012 00:40:18 -0500] rev 4641
By request, switch to 10.7 to take full advantage of ARC.

3 months agoARC-ify AdiumLibpurple. ARC
Frank Dowsett <wixardy@adium.im> [Thu, 02 Feb 2012 00:40:18 -0500] rev 4640
ARC-ify AdiumLibpurple.

3 months agoARC-ify AIUtilities. ARC
Frank Dowsett <wixardy@adium.im> [Thu, 02 Feb 2012 00:40:15 -0500] rev 4639
ARC-ify AIUtilities.

3 months agoImprovements to the change logs.
Robert Vehse [Thu, 02 Feb 2012 00:16:44 +0100] rev 4638
Improvements to the change logs.

3 months agoFixed contact list wrong position at start-up under Mac OS X Lion. Fix suggested by wixardy. Fixes #15341. Fixes #15480.
Adrian Godoroja <robotive@me.com> [Wed, 01 Feb 2012 22:47:32 +0200] rev 4637
Fixed contact list wrong position at start-up under Mac OS X Lion. Fix suggested by wixardy. Fixes #15341. Fixes #15480.

3 months agoUpdated Makefile.
Adrian Godoroja <robotive@me.com> [Wed, 01 Feb 2012 21:07:34 +0200] rev 4636
Updated Makefile.

3 months ago1.5rc3
Adrian Godoroja <robotive@me.com> [Wed, 01 Feb 2012 20:59:57 +0200] rev 4635
1.5rc3

3 months agoFinished the sentence of this comment.
Thijs Alkemade <thijsalkemade@gmail.com> [Wed, 01 Feb 2012 12:45:52 +0100] rev 4634
Finished the sentence of this comment.

3 months agoBlacklist the Skype plugin in 1.5, as it's known to be broken.
Thijs Alkemade <thijsalkemade@gmail.com> [Wed, 01 Feb 2012 12:41:03 +0100] rev 4633
Blacklist the Skype plugin in 1.5, as it's known to be broken.

I know this introduces new strings that probably will not be translated in time, but too many people have it installed and don't know they need to update it.

3 months agoThis works better then previous way.
Adrian Godoroja <robotive@me.com> [Tue, 31 Jan 2012 16:38:56 +0200] rev 4632
This works better then previous way.

3 months agoBetter way of using two Xcode versions.
Adrian Godoroja <robotive@me.com> [Tue, 31 Jan 2012 14:28:11 +0200] rev 4631
Better way of using two Xcode versions.

3 months agoMake use of the scores when searching in preferences and select the best match. Fixes #15796 PreferencesRedux
Frank Dowsett <wixardy@adium.im> [Mon, 30 Jan 2012 18:35:48 -0500] rev 4630
Make use of the scores when searching in preferences and select the best match. Fixes #15796

3 months agoRename 'Message Style' pane to 'Message View' fixing #15802. PreferencesRedux
Frank Dowsett <wixardy@adium.im> [Mon, 30 Jan 2012 14:45:06 -0500] rev 4629
Rename 'Message Style' pane to 'Message View' fixing #15802.

3 months agoFix #15801 by defining a minimum width for the preferences window. PreferencesRedux
Frank Dowsett <wixardy@adium.im> [Mon, 30 Jan 2012 14:41:57 -0500] rev 4628
Fix #15801 by defining a minimum width for the preferences window.

3 months agoA better fix for 281ad094f064 which caused the search terms to be skipped. PreferencesRedux
Frank Dowsett <wixardy@adium.im> [Mon, 30 Jan 2012 14:34:59 -0500] rev 4627
A better fix for 281ad094f064 which caused the search terms to be skipped.

3 months agoUpdated Italian localisation for 1.5rc2 from pi++. Fixes #15810. Fixes #15808.
Robert Vehse [Mon, 30 Jan 2012 22:23:06 +0100] rev 4626
Updated Italian localisation for 1.5rc2 from pi++. Fixes #15810. Fixes #15808.

3 months agoMerged
Thijs Alkemade <thijsalkemade@gmail.com> [Mon, 30 Jan 2012 20:21:11 +0100] rev 4625
Merged

3 months agoRemove the hard-coded server name for LiveJournal accounts, they have an SRV record now.
Thijs Alkemade <thijsalkemade@gmail.com> [Mon, 30 Jan 2012 20:18:42 +0100] rev 4624
Remove the hard-coded server name for LiveJournal accounts, they have an SRV record now.

Fixes #15777

3 months agoFix version requirement. Also fix minor changelogging boo-boos.
Robert Vehse [Mon, 30 Jan 2012 00:41:11 +0100] rev 4623
Fix version requirement. Also fix minor changelogging boo-boos.

3 months agoUpdated change logs.
Robert Vehse [Sun, 29 Jan 2012 23:45:33 +0100] rev 4622
Updated change logs.

3 months agoForgot to refactor this part calling ESPresetNameSheetController.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 23:38:19 +0100] rev 4621
Forgot to refactor this part calling ESPresetNameSheetController.

3 months agoUpdated LMX. Removed PPC stuff.
Adrian Godoroja <robotive@me.com> [Mon, 30 Jan 2012 00:19:49 +0200] rev 4620
Updated LMX. Removed PPC stuff.

3 months agoAdded -DNS_BLOCK_ASSERTIONS to JSONKit to improve performance.
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 23:19:23 +0200] rev 4619
Added -DNS_BLOCK_ASSERTIONS to JSONKit to improve performance.

3 months agoUpdated OAuthConsumer. Removed PPC stuff.
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 23:02:15 +0200] rev 4618
Updated OAuthConsumer. Removed PPC stuff.

3 months agoRefactored AINewContactWindowController to be acceptable to the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 21:25:13 +0100] rev 4617
Refactored AINewContactWindowController to be acceptable to the static analyzer.

3 months agoKeep the NSConnection AIAdium creates around, so the static analyzer can be happy about it.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 21:24:57 +0100] rev 4616
Keep the NSConnection AIAdium creates around, so the static analyzer can be happy about it.

3 months agoMerged
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 21:00:22 +0100] rev 4615
Merged

3 months agoThis autorelease was wrong, the superclass calls [self autorelease] in -windowWillClose:. Made sure that's commented everywhere.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 20:59:55 +0100] rev 4614
This autorelease was wrong, the superclass calls [self autorelease] in -windowWillClose:. Made sure that's commented everywhere.

3 months agoFixed three new warnings that were introduced in the static analyzer (showOnWindow: is marked to release the receiver, so don't use it after calling it).
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 20:51:46 +0100] rev 4613
Fixed three new warnings that were introduced in the static analyzer (showOnWindow: is marked to release the receiver, so don't use it after calling it).

3 months agoRemoved a bunch of broken links/references to frameworks, looks like used and removed by the AV branch.
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 20:56:07 +0200] rev 4612
Removed a bunch of broken links/references to frameworks, looks like used and removed by the AV branch.

3 months agoUpdated JSONKit. Looks like analyzer won't complain anymore.
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 20:34:24 +0200] rev 4611
Updated JSONKit. Looks like analyzer won't complain anymore.

3 months agoRefactor SHLinkEditorWindowController and ESPresetNameSheetController to be accepted by the static analyzer, and fix leaking when closing.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 19:28:56 +0100] rev 4610
Refactor SHLinkEditorWindowController and ESPresetNameSheetController to be accepted by the static analyzer, and fix leaking when closing.

3 months agoSome more annotations to AIAccount about authorization requests, I think the static analyzer is still not happy with it, though.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 19:03:22 +0100] rev 4609
Some more annotations to AIAccount about authorization requests, I think the static analyzer is still not happy with it, though.

3 months agoESOTRPrivateKeyGenerationWindowController doesn't need to release itself in the -windowWillClose, but that does mean it leaks here.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 19:02:46 +0100] rev 4608
ESOTRPrivateKeyGenerationWindowController doesn't need to release itself in the -windowWillClose, but that does mean it leaks here.

3 months agoRefactor ESPresetManagementController to be acceptable to the static analyzer, and fix it leaking after closing the window.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 18:38:31 +0100] rev 4607
Refactor ESPresetManagementController to be acceptable to the static analyzer, and fix it leaking after closing the window.

3 months agoRefactor and annotate AdiumSetupWizard to be acceptable to the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 18:24:44 +0100] rev 4606
Refactor and annotate AdiumSetupWizard to be acceptable to the static analyzer.

3 months agoThis plugin is never unloaded, but handle it just in case, so this doesn't look like a leak.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 18:21:54 +0100] rev 4605
This plugin is never unloaded, but handle it just in case, so this doesn't look like a leak.

3 months agoAnnotate XtrasInstaller to be acceptable for the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 18:21:29 +0100] rev 4604
Annotate XtrasInstaller to be acceptable for the static analyzer.

3 months agoRefactor AIListLayoutWindowController to be acceptable to the static analyzer, and fix it leaking after closing the window.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 18:12:22 +0100] rev 4603
Refactor AIListLayoutWindowController to be acceptable to the static analyzer, and fix it leaking after closing the window.

3 months agoRefactor ESTextAndButtonsWindowController and ESEditStatusGroupWindowController to be acceptable to the static analyzer, and fix them leaking after closing the window.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 18:04:23 +0100] rev 4602
Refactor ESTextAndButtonsWindowController and ESEditStatusGroupWindowController to be acceptable to the static analyzer, and fix them leaking after closing the window.

3 months agoCorrect 065615aec05d. Apparently, in Mac OS X (English) all words in menu items are capitalised.
Robert Vehse [Sun, 29 Jan 2012 17:55:50 +0100] rev 4601
Correct 065615aec05d. Apparently, in Mac OS X (English) all words in menu items are capitalised.

3 months ago1.5rc2
Eric Richie [Sun, 29 Jan 2012 11:48:45 -0500] rev 4600
1.5rc2

3 months agoLinked the rest of the used libs, to the Xcode project.
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 18:05:45 +0200] rev 4599
Linked the rest of the used libs, to the Xcode project.

3 months agoAdded this back. http://hg.adium.im/adium/rev/6c3cd092c3d4
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 17:56:19 +0200] rev 4598
Added this back. http://hg.adium.im/adium/rev/6c3cd092c3d4

3 months agoUpdate ShortcutRecorder.
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 17:48:40 +0200] rev 4597
Update ShortcutRecorder.

3 months agoMove those two to the appropriate directory.
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 17:47:10 +0200] rev 4596
Move those two to the appropriate directory.

3 months agoRefactor AINewBookmarkWindowController to be acceptable to the static analyzer, and fix it leaking after closing the window.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 16:33:47 +0100] rev 4595
Refactor AINewBookmarkWindowController to be acceptable to the static analyzer, and fix it leaking after closing the window.

3 months agoRefactored AINewGroupWindowController to be acceptable to the static analyzer, and fix it leaking after closing the window.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 16:15:42 +0100] rev 4594
Refactored AINewGroupWindowController to be acceptable to the static analyzer, and fix it leaking after closing the window.

3 months agoRefactored AITemporaryIRCAccountWindowController to be acceptable to the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 16:04:43 +0100] rev 4593
Refactored AITemporaryIRCAccountWindowController to be acceptable to the static analyzer.

3 months agoRefactored AIListThemeWindowController to be acceptable to the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 15:59:53 +0100] rev 4592
Refactored AIListThemeWindowController to be acceptable to the static analyzer.

3 months agoI think this way is better, to avoid saving the frame of the sheet as if it were a window.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 15:49:48 +0100] rev 4591
I think this way is better, to avoid saving the frame of the sheet as if it were a window.

3 months agoRefactored AIEditAccountWindowController to be acceptable to the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 15:47:25 +0100] rev 4590
Refactored AIEditAccountWindowController to be acceptable to the static analyzer.

3 months agoRefactored AIDockIconSelectionSheet into a way the static analyzer accepts.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 15:21:31 +0100] rev 4589
Refactored AIDockIconSelectionSheet into a way the static analyzer accepts.

3 months agoFix a couple of leaks and incorrect memory management in AIEmoticonPreferences, also, create and open it in a way the static analyzer will accept.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 15:11:57 +0100] rev 4588
Fix a couple of leaks and incorrect memory management in AIEmoticonPreferences, also, create and open it in a way the static analyzer will accept.

3 months agoUpdated FriBidi to version 2 (0.19.2). Fixed few analyzer warnings.
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 14:55:46 +0200] rev 4587
Updated FriBidi to version 2 (0.19.2). Fixed few analyzer warnings.

3 months agoThis leak fix was wrong. NSWindowController subclasses aren't released until -windowWillClose:
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 13:44:41 +0100] rev 4586
This leak fix was wrong. NSWindowController subclasses aren't released until -windowWillClose:

3 months agoAvoid a lot of false positives of the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 02:53:09 +0100] rev 4585
Avoid a lot of false positives of the static analyzer.

3 months agoBackout my changes to immutableCopy and use __attribute__((objc_method_family(copy))), as pointed out by Peter Hosey.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 01:58:12 +0100] rev 4584
Backout my changes to immutableCopy and use __attribute__((objc_method_family(copy))), as pointed out by Peter Hosey.

3 months agoAnother bunch of leak fixes, found by the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 01:41:57 +0100] rev 4583
Another bunch of leak fixes, found by the static analyzer.

3 months agoFix another bunch of leaks found by the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 00:59:22 +0100] rev 4582
Fix another bunch of leaks found by the static analyzer.

3 months agoRename our immutableCopy to copyImmutable, to avoid a lot of false positive analyzer warnings.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 00:58:47 +0100] rev 4581
Rename our immutableCopy to copyImmutable, to avoid a lot of false positive analyzer warnings.

3 months agoFix leaks in the deallocation of AIMetaContacts, found (partially) by the static analyzer.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 00:36:10 +0100] rev 4580
Fix leaks in the deallocation of AIMetaContacts, found (partially) by the static analyzer.

3 months agoFix a couple of leaks found by the static analyzer in the initialization of the AILoggerPlugin.
Thijs Alkemade <thijsalkemade@gmail.com> [Sun, 29 Jan 2012 00:34:28 +0100] rev 4579
Fix a couple of leaks found by the static analyzer in the initialization of the AILoggerPlugin.

3 months agoFixed 3 "Call to free data when error was returned during allocation" in AIKeychain. Analyzer Warnings--.
Adrian Godoroja <robotive@me.com> [Sun, 29 Jan 2012 00:27:00 +0200] rev 4578
Fixed 3 "Call to free data when error was returned during allocation" in AIKeychain. Analyzer Warnings--.

3 months agoFixed a bunch of "Argument to 'NSDictionary' method 'dictionaryWithObjectsAndKeys:' should be an Objective-C pointer type, not '_SOME_Ref'". Analyzer Warnings--.
Adrian Godoroja <robotive@me.com> [Sat, 28 Jan 2012 22:43:36 +0200] rev 4577
Fixed a bunch of "Argument to 'NSDictionary' method 'dictionaryWithObjectsAndKeys:' should be an Objective-C pointer type, not '_SOME_Ref'". Analyzer Warnings--.

3 months agoMinor fix to previous fix :).
Adrian Godoroja <robotive@me.com> [Fri, 27 Jan 2012 18:43:27 +0200] rev 4576
Minor fix to previous fix :).

3 months agoFixed a mega bunch of "Method accepting NSError** should have a non-void return value to indicate whether or not an error occurred". Analyzer Warnings--.
Adrian Godoroja <robotive@me.com> [Fri, 27 Jan 2012 18:19:55 +0200] rev 4575
Fixed a mega bunch of "Method accepting NSError** should have a non-void return value to indicate whether or not an error occurred". Analyzer Warnings--.

3 months agoMake some search terms match their group's title so that searching for tooltips works like it should. PreferencesRedux
Frank Dowsett <wixardy@adium.im> [Fri, 27 Jan 2012 10:46:04 -0500] rev 4574
Make some search terms match their group's title so that searching for tooltips works like it should.

3 months agoUse different icons for preferences messages and window handling than the duplicates they were using. PreferencesRedux
Frank Dowsett <wixardy@adium.im> [Fri, 27 Jan 2012 10:44:21 -0500] rev 4573
Use different icons for preferences messages and window handling than the duplicates they were using.

3 months agoFixed "Argument in message expression is an uninitialized value" in AIChat.m. Analyzer Warnings--.
Adrian Godoroja <robotive@me.com> [Fri, 27 Jan 2012 12:54:07 +0200] rev 4572
Fixed "Argument in message expression is an uninitialized value" in AIChat.m. Analyzer Warnings--.

3 months agoFixed "Value stored to 'level' during its initialization is never read". Analyzer Warnings--.
Adrian Godoroja <robotive@me.com> [Fri, 27 Jan 2012 02:02:08 +0200] rev 4571
Fixed "Value stored to 'level' during its initialization is never read". Analyzer Warnings--.

3 months agoFixed 2 "The right operand to '-' is always 0". Analyzer Warnings--.
Adrian Godoroja <robotive@me.com> [Fri, 27 Jan 2012 01:36:07 +0200] rev 4570
Fixed 2 "The right operand to '-' is always 0". Analyzer Warnings--.

3 months agoFixed a bunch of "Value stored to 'OBJECT' is never read". Analyzer Warnings--.
Adrian Godoroja <robotive@me.com> [Fri, 27 Jan 2012 01:23:38 +0200] rev 4569
Fixed a bunch of "Value stored to 'OBJECT' is never read". Analyzer Warnings--.