8 months agoAdded the actual auth mech. Signing in works, though it is still called "Facebook" everywhere. MSN-XMPP
Thijs Alkemade <thijsalkemade@gmail.com> [Thu, 15 Sep 2011 16:23:06 +0200] rev 4211
Added the actual auth mech. Signing in works, though it is still called "Facebook" everywhere.

8 months agoRetrieving the auth_token now works for MSN. MSN-XMPP
Thijs Alkemade <thijsalkemade@gmail.com> [Thu, 15 Sep 2011 11:42:43 +0200] rev 4210
Retrieving the auth_token now works for MSN.

8 months agoAdding a new OAuth2-XMPP subclass'ed MSN account type. MSN-XMPP
Thijs Alkemade <thijsalkemade@gmail.com> [Thu, 15 Sep 2011 11:19:25 +0200] rev 4209
Adding a new OAuth2-XMPP subclass'ed MSN account type.

8 months agoStarting with abstracting the OAuth2 stuff from Facebook into a way that can be shared with the new XMPP MSN method. MSN-XMPP
Thijs Alkemade <thijsalkemade@gmail.com> [Thu, 15 Sep 2011 11:07:10 +0200] rev 4208
Starting with abstracting the OAuth2 stuff from Facebook into a way that can be shared with the new XMPP MSN method.

8 months agoPatch by kbotc: "The origin of this view should be at -1. You can see proof in the xib". Fixes #15396.
Robert Vehse [Tue, 13 Sep 2011 03:01:22 +0200] rev 4207
Patch by kbotc: "The origin of this view should be at -1. You can see proof in the xib". Fixes #15396.

8 months agoPatch by kbotc: "Undo 1fb2992a10d6 and stll don't leak. Refs #14294."
Robert Vehse [Wed, 07 Sep 2011 23:59:09 +0200] rev 4206
Patch by kbotc: "Undo 1fb2992a10d6 and stll don't leak. Refs #14294."

8 months agoAdded isOnLionOrNewer.
Adrian Godoroja <robotive@me.com> [Thu, 08 Sep 2011 00:55:39 +0300] rev 4205
Added isOnLionOrNewer.

8 months agoFix the annoying 1px borders of SplitView in LogViewer.
Adrian Godoroja <robotive@me.com> [Mon, 05 Sep 2011 15:16:02 +0300] rev 4204
Fix the annoying 1px borders of SplitView in LogViewer.

8 months agoUpdate Credits.rtf.
Robert Vehse [Mon, 05 Sep 2011 13:05:32 +0200] rev 4203
Update Credits.rtf.

8 months agoFix the annoying 1px borders of SplitView in MessageView.
Adrian Godoroja <robotive@me.com> [Mon, 05 Sep 2011 03:27:28 +0300] rev 4202
Fix the annoying 1px borders of SplitView in MessageView.

8 months agoFixed a bunch of nib warnings/errors [3].
Adrian Godoroja <robotive@me.com> [Mon, 05 Sep 2011 00:11:28 +0300] rev 4201
Fixed a bunch of nib warnings/errors [3].

8 months agoFixed a bunch of nib warnings/errors [2].
Adrian Godoroja <robotive@me.com> [Mon, 05 Sep 2011 00:11:28 +0300] rev 4200
Fixed a bunch of nib warnings/errors [2].

8 months agoFixed a bunch of nib warnings/errors [1].
Adrian Godoroja <robotive@me.com> [Mon, 05 Sep 2011 00:09:20 +0300] rev 4199
Fixed a bunch of nib warnings/errors [1].

8 months agoMerged
Thijs Alkemade <thijsalkemade@gmail.com> [Mon, 05 Sep 2011 00:41:02 +0200] rev 4198
Merged

8 months agorobotive committed some stuff he didn't mean to, fixing his merge.
Thijs Alkemade <thijsalkemade@gmail.com> [Mon, 05 Sep 2011 00:40:39 +0200] rev 4197
robotive committed some stuff he didn't mean to, fixing his merge.
Backed out changeset 0520aad6e21e

8 months agoFixed merge. robotive committed some stuff he didn't mean to
Thijs Alkemade <thijsalkemade@gmail.com> [Mon, 05 Sep 2011 00:36:24 +0200] rev 4196
Fixed merge. robotive committed some stuff he didn't mean to

8 months agoMerging! (Don't forget to Pull before committing!)
Adrian Godoroja <robotive@me.com> [Mon, 05 Sep 2011 01:01:11 +0300] rev 4195
Merging! (Don't forget to Pull before committing!)

8 months agoFixed a bunch of nib warnings/errors [3].
Adrian Godoroja <robotive@me.com> [Mon, 05 Sep 2011 00:11:15 +0300] rev 4194
Fixed a bunch of nib warnings/errors [3].

8 months agoFixed a bunch of nib warnings/errors [2].
Adrian Godoroja <robotive@me.com> [Mon, 05 Sep 2011 00:10:42 +0300] rev 4193
Fixed a bunch of nib warnings/errors [2].

8 months agoFixed a bunch of nib warnings/errors [1].
Adrian Godoroja <robotive@me.com> [Mon, 05 Sep 2011 00:10:15 +0300] rev 4192
Fixed a bunch of nib warnings/errors [1].

8 months agoTesting... Testing...
Eric Richie [Sun, 04 Sep 2011 16:59:55 -0400] rev 4191
Testing... Testing...

8 months agoPatch by kbotc: "A better solution. If there is less than or equal to 1 chat left for the listObject, go ahead and destroy it. (We were never removing AIListObjects when they were in chats because they were considered contained by the closing chat when we were supposed to be deallocating them, thus leading to a leak)" Refs #14294.
Robert Vehse [Tue, 30 Aug 2011 22:35:21 +0200] rev 4190
Patch by kbotc: "A better solution. If there is less than or equal to 1 chat left for the listObject, go ahead and destroy it. (We were never removing AIListObjects when they were in chats because they were considered contained by the closing chat when we were supposed to be deallocating them, thus leading to a leak)" Refs #14294.

Add kbotc to our list of developers. He should fix his commit access!

8 months agoAdd "yelly" to our list of contributors.
Robert Vehse [Tue, 30 Aug 2011 22:21:30 +0200] rev 4189
Add "yelly" to our list of contributors.

8 months agoDon't attempt to reuse the AIProxyListObject associated with a leaked ESObjectWithProperties; discard further use of it, clear its cache, and make a new one. Fixes #14294. Thanks to '''kbotc''' for the solution.
Evan Schoenberg [Mon, 29 Aug 2011 19:43:00 -0500] rev 4188
Don't attempt to reuse the AIProxyListObject associated with a leaked ESObjectWithProperties; discard further use of it, clear its cache, and make a new one. Fixes #14294. Thanks to '''kbotc''' for the solution.

9 months agoIncreased comment detail
Evan Schoenberg [Sun, 28 Aug 2011 21:08:25 -0500] rev 4187
Increased comment detail

9 months agoI have a theory that this may be the solution to the remaining AIProxyListObject crash issue; if the userlist is hidden, as it is by default in the Twitter timeline, then items in the list could previously deallocate without us calling reloadData. The list might try to access its data even if it's not visible if it's is calculating frame heights - and all the recent crashes are in:
Evan Schoenberg [Sun, 28 Aug 2011 21:07:02 -0500] rev 4186
I have a theory that this may be the solution to the remaining AIProxyListObject crash issue; if the userlist is hidden, as it is by default in the Twitter timeline, then items in the list could previously deallocate without us calling reloadData. The list might try to access its data even if it's not visible if it's is calculating frame heights - and all the recent crashes are in:
{{{
com.apple.AppKit 0x9185c751 -[NSTableView _minimumFrameSize] + 72
com.apple.AppKit 0x91866cfc -[NSTableView tile] + 252
com.apple.AppKit 0x9189dd4e -[NSTableView viewWillDraw] + 75
com.apple.AppKit 0x9189d862 -[NSView viewWillDraw] + 621
}}}

Refs #14294. Please report if you can reproduce the crash after this commit.

9 months agoDate update. Thanks, Peter
Evan Schoenberg [Sun, 28 Aug 2011 19:41:38 -0500] rev 4185
Date update. Thanks, Peter

9 months agoThis now indicates a simple leak; quiet it down and move it into our debug logging
Evan Schoenberg [Sun, 28 Aug 2011 19:17:33 -0500] rev 4184
This now indicates a simple leak; quiet it down and move it into our debug logging

9 months agoDeloggify
Evan Schoenberg [Sun, 28 Aug 2011 19:16:20 -0500] rev 4183
Deloggify

9 months agoFixes inconsistency with "Get Info" and "Show Info". Fixes #14072.
Ariel "yelly" Chinn <arielchinn@gmail.com> [Sun, 28 Aug 2011 00:34:56 +0300] rev 4182
Fixes inconsistency with "Get Info" and "Show Info". Fixes #14072.

9 months agoAdds some more info to the quit confirmation dialog. Refs #4800.
Ariel "yelly" Chinn <arielchinn@gmail.com> [Sat, 27 Aug 2011 21:29:20 +0300] rev 4181
Adds some more info to the quit confirmation dialog. Refs #4800.

9 months agoUpdated British English localisation for 1.4.3.
Robert Vehse [Sat, 27 Aug 2011 21:08:45 +0200] rev 4180
Updated British English localisation for 1.4.3.

9 months agoPatch from kbotc which fixes a leak with Status.net.
Thijs Alkemade <thijsalkemade@gmail.com> [Tue, 23 Aug 2011 21:37:53 +0200] rev 4179
Patch from kbotc which fixes a leak with Status.net.

9 months ago* Don't have -[AIChat containedObjects] return copy/autoreleased array. It confuses my memory management tracking and is unnecessarily inefficient when the most common use case uses it without mutation of the chat.
Evan Schoenberg [Mon, 22 Aug 2011 21:11:40 -0500] rev 4178
* Don't have -[AIChat containedObjects] return copy/autoreleased array. It confuses my memory management tracking and is unnecessarily inefficient when the most common use case uses it without mutation of the chat.
* Fix a logic error I introduced in a previous commit in -[AIChat removeAllParticipatingContactsSilently] and added a comment to avoid future confusion in the same way
* Change a copy/autorelease into copy/.../release, again to simplify memory management tracking

9 months agoCan't throw a brick without finding a leak around here...
Evan Schoenberg [Mon, 22 Aug 2011 21:09:06 -0500] rev 4177
Can't throw a brick without finding a leak around here...

9 months agoNo need to declare this
Evan Schoenberg [Mon, 22 Aug 2011 20:32:22 -0500] rev 4176
No need to declare this

9 months agoProvide some retain/release protection around the property notifications when removing objects from groups. This probably has no real effect because the calls to it already have retain/autorelease, but it makes me feel better and is safer. Refs #14294
Evan Schoenberg [Mon, 22 Aug 2011 20:30:01 -0500] rev 4175
Provide some retain/release protection around the property notifications when removing objects from groups. This probably has no real effect because the calls to it already have retain/autorelease, but it makes me feel better and is safer. Refs #14294

9 months agoNobody should be releasing proxy objects externally; this should only be done when the AIListObject deallocates. Refs #14294
Evan Schoenberg [Mon, 22 Aug 2011 20:27:16 -0500] rev 4174
Nobody should be releasing proxy objects externally; this should only be done when the AIListObject deallocates. Refs #14294

9 months agoFix opening the Twitter timeline chat, which was broken in [9df931e22bfe]; accounts can now specify whether or not they require a chatCreationInfo dictionary
Evan Schoenberg [Mon, 22 Aug 2011 17:41:16 -0500] rev 4173
Fix opening the Twitter timeline chat, which was broken in [9df931e22bfe]; accounts can now specify whether or not they require a chatCreationInfo dictionary

9 months agoPatch from kbotc based on one by brion: allow overriding the 140 character limit for StatusNet. Fixes #13485.
Robert Vehse [Mon, 22 Aug 2011 22:19:05 +0200] rev 4172
Patch from kbotc based on one by brion: allow overriding the 140 character limit for StatusNet. Fixes #13485.

9 months agoThis turns on the Lion overlay scrollers. The markings seem to still work, but they look a bit small to me.
Thijs Alkemade <thijsalkemade@gmail.com> [Mon, 22 Aug 2011 13:06:41 +0200] rev 4171
This turns on the Lion overlay scrollers. The markings seem to still work, but they look a bit small to me.

Refs #15394

9 months agoFix the build and lazy init the proxyDict for proxyListObjects
Stephen Holt <sholt@adium.im> [Sun, 21 Aug 2011 23:32:43 -0700] rev 4170
Fix the build and lazy init the proxyDict for proxyListObjects

9 months agoUpon further reflection, MAZeroingWeakRef isn't necessary for AIProxyListObject; removing it. We maintain a safe weak reference, because the AIProxyListObject will only be deallocated after its AIListObject deallocates. There may be some edge case with the containing object, but I can't visualize or reproduce a problem, and a zeroing weak ref is probably too heavy and would just be masking some other problem.
Evan Schoenberg [Sun, 21 Aug 2011 21:12:54 -0500] rev 4169
Upon further reflection, MAZeroingWeakRef isn't necessary for AIProxyListObject; removing it. We maintain a safe weak reference, because the AIProxyListObject will only be deallocated after its AIListObject deallocates. There may be some edge case with the containing object, but I can't visualize or reproduce a problem, and a zeroing weak ref is probably too heavy and would just be masking some other problem.

9 months agoRemoved MAZeroingWeakRef
Evan Schoenberg [Sun, 21 Aug 2011 21:08:33 -0500] rev 4168
Removed MAZeroingWeakRef

9 months agoBacked out project changes for MAZeroingWeakRef
Evan Schoenberg [Sun, 21 Aug 2011 21:08:16 -0500] rev 4167
Backed out project changes for MAZeroingWeakRef

9 months agobacked out credits updates for MAZeroingWeakRef
Evan Schoenberg [Sun, 21 Aug 2011 21:07:53 -0500] rev 4166
backed out credits updates for MAZeroingWeakRef

9 months agoBacked out changeset 4a87584e9e3a
Evan Schoenberg [Sun, 21 Aug 2011 21:07:09 -0500] rev 4165
Backed out changeset 4a87584e9e3a

9 months agoAdded MAZeroingWeakRef's license information to our license.txt
Evan Schoenberg [Sun, 21 Aug 2011 16:37:35 -0500] rev 4164
Added MAZeroingWeakRef's license information to our license.txt

9 months agoAdded MAZeroingWeakRef to the credits
Evan Schoenberg [Sun, 21 Aug 2011 16:36:20 -0500] rev 4163
Added MAZeroingWeakRef to the credits

9 months agoProject updates to add MAZeroingWeakRef and friends
Evan Schoenberg [Sun, 21 Aug 2011 16:34:37 -0500] rev 4162
Project updates to add MAZeroingWeakRef and friends

9 months agoAIProxyListObject no longer retains the ESObjectWithProperties which retains it; instead, it maintains a zeroing weak reference. This simplifies the memory management significantly.
Evan Schoenberg [Sun, 21 Aug 2011 16:34:04 -0500] rev 4161
AIProxyListObject no longer retains the ESObjectWithProperties which retains it; instead, it maintains a zeroing weak reference. This simplifies the memory management significantly.
* Don't try to aggressively release AIProxyListObjects when a group is collapsed. Instead, clear out its display cache. At that point, it's a very small object, and it can live until the AIListObject is deallocated.
* Although messaging the AIProxyListObject results in a call through to -[AIPorxyListObject listObject], it's clearer to use this directly. (Future changes should probably remove its 'mirroring' capability entirely; it's just a set up for confusion and mis-casting).
* I believe that between this and kbotc's changes, this fixes #14294. I never could reproduce the crash in the first place, though. Please test and report back.

9 months agowarnings--;
Evan Schoenberg [Sun, 21 Aug 2011 16:19:20 -0500] rev 4160
warnings--;

9 months agoSilenced some more nib warnings in xcode 4.2
Evan Schoenberg [Sun, 21 Aug 2011 16:18:55 -0500] rev 4159
Silenced some more nib warnings in xcode 4.2

9 months agoAdded MAZeroingWeakRef
Evan Schoenberg [Sun, 21 Aug 2011 16:17:51 -0500] rev 4158
Added MAZeroingWeakRef

9 months agoFixed the last retain-loop I found for AIChat; AIChat once more deallocates properly. Also, fixed behavior of removeAllParticipatingContactsSilently to work even if the chat isn't closing (though when we use it, it currently is... this is just less fragile).
Evan Schoenberg [Sun, 21 Aug 2011 16:15:48 -0500] rev 4157
Fixed the last retain-loop I found for AIChat; AIChat once more deallocates properly. Also, fixed behavior of removeAllParticipatingContactsSilently to work even if the chat isn't closing (though when we use it, it currently is... this is just less fragile).

9 months agoIn what must be the longest standing leak in the history of Adium, we weren't releasing the view heirarchy owned by AIMessageViewController (since it loads it with itself as owner from the nib in its init method). This, in turn, made every AIChat leak, since AIMessageTextEntryView retains its AIChat...
Evan Schoenberg [Sun, 21 Aug 2011 15:50:25 -0500] rev 4156
In what must be the longest standing leak in the history of Adium, we weren't releasing the view heirarchy owned by AIMessageViewController (since it loads it with itself as owner from the nib in its init method). This, in turn, made every AIChat leak, since AIMessageTextEntryView retains its AIChat...

9 months agoApply the same fix as a00b7964253b, but for group chats, again resolving a double-retain
Evan Schoenberg [Sun, 21 Aug 2011 15:14:33 -0500] rev 4155
Apply the same fix as a00b7964253b, but for group chats, again resolving a double-retain

9 months agoFix an AIChat leak caused by a double-retain via recursion within imChatLookupFromConv()
Evan Schoenberg [Sun, 21 Aug 2011 15:06:27 -0500] rev 4154
Fix an AIChat leak caused by a double-retain via recursion within imChatLookupFromConv()

9 months agoSilence a number of warnings about checkboxes and their scaling
Evan Schoenberg [Sun, 21 Aug 2011 15:02:41 -0500] rev 4153
Silence a number of warnings about checkboxes and their scaling

9 months agoUpdated Danish localisation for 1.4.3 from Thain. Refs #15431.
Robert Vehse [Thu, 18 Aug 2011 22:08:57 +0200] rev 4152
Updated Danish localisation for 1.4.3 from Thain. Refs #15431.

9 months agoUpdated Dutch localisation for 1.4.3 from digistorm. Refs #15421.
Robert Vehse [Thu, 18 Aug 2011 19:58:02 +0200] rev 4151
Updated Dutch localisation for 1.4.3 from digistorm. Refs #15421.

9 months agoAdding some missing German translated strings.
Robert Vehse [Thu, 18 Aug 2011 02:21:31 +0200] rev 4150
Adding some missing German translated strings.

Also: changelogging.

9 months agoAdded Facebook to Address Book Integration. Patch by kbotc. Fixes #13755.
Adrian Godoroja <robotive@me.com> [Wed, 17 Aug 2011 20:41:04 +0300] rev 4149
Added Facebook to Address Book Integration. Patch by kbotc. Fixes #13755.

9 months agoFixed context-messages showing up even if logging is entirely disabled. Fixes #12577.
Patrick Steinhardt <steinhardt.p@me.com> [Tue, 16 Aug 2011 22:39:53 +0200] rev 4148
Fixed context-messages showing up even if logging is entirely disabled. Fixes #12577.

9 months agoBacked out changeset 1e84ee0e55a9, it was used in a NIB.
Patrick Steinhardt <steinhardt.p@me.com> [Tue, 16 Aug 2011 22:17:08 +0200] rev 4147
Backed out changeset 1e84ee0e55a9, it was used in a NIB.

9 months agoRemoved AIWindowDraggingView as it is not in use.
Patrick Steinhardt <steinhardt.p@me.com> [Tue, 16 Aug 2011 19:42:43 +0200] rev 4146
Removed AIWindowDraggingView as it is not in use.

9 months agoI was told this means less leaking.
Robert Vehse [Tue, 16 Aug 2011 01:39:04 +0200] rev 4145
I was told this means less leaking.

9 months agoPatch from kbotc: "If you can see the object, it has to already exist". Refs #14294.
Robert Vehse [Mon, 15 Aug 2011 23:21:51 +0200] rev 4144
Patch from kbotc: "If you can see the object, it has to already exist". Refs #14294.

9 months agoPatch from kbotc: "Following Apple's documentation, we won't reload the children if they're not visible". Refs #14294.
Robert Vehse [Mon, 15 Aug 2011 23:19:09 +0200] rev 4143
Patch from kbotc: "Following Apple's documentation, we won't reload the children if they're not visible". Refs #14294.

9 months agoUpdated French localisation for 1.4.3 from Armas. Also removed some localised versions of ESPurpleJabberAccountView.nib which I mistakenly added with the past couple of localisation updates.
Robert Vehse [Sat, 13 Aug 2011 21:05:24 +0200] rev 4142
Updated French localisation for 1.4.3 from Armas. Also removed some localised versions of ESPurpleJabberAccountView.nib which I mistakenly added with the past couple of localisation updates.

9 months agoThe category should not override the class's dealloc method; doing so leads to leakage. This was in AIAccount, which we don't dealloc often, so not a huge deal... but do it right nonetheless. Warnings--;
Evan Schoenberg [Thu, 11 Aug 2011 19:33:21 -0500] rev 4141
The category should not override the class's dealloc method; doing so leads to leakage. This was in AIAccount, which we don't dealloc often, so not a huge deal... but do it right nonetheless. Warnings--;

9 months agoResolve a warning by not overriding an instance method in a category
Evan Schoenberg [Thu, 11 Aug 2011 19:31:37 -0500] rev 4140
Resolve a warning by not overriding an instance method in a category

9 months agoSilence a number of warnings related to sv.lproj's nib files
Evan Schoenberg [Thu, 11 Aug 2011 19:17:31 -0500] rev 4139
Silence a number of warnings related to sv.lproj's nib files

9 months agoUpdated Greek localisation for 1.4.3 from tzikis with some minor nib adjustments from me.
Robert Vehse [Thu, 11 Aug 2011 23:39:37 +0200] rev 4138
Updated Greek localisation for 1.4.3 from tzikis with some minor nib adjustments from me.

9 months agoUpdated German localisation for 1.4.3 from mwulftange. Refs #15374, refs #15393.
Robert Vehse [Thu, 11 Aug 2011 22:46:57 +0200] rev 4137
Updated German localisation for 1.4.3 from mwulftange. Refs #15374, refs #15393.