2009-04-09Don't validate command menu items when no list objects are selected.
Zachary West <zacw@adiumx.com> [Thu, 09 Apr 2009 02:14:33 +0000] rev 1618
Don't validate command menu items when no list objects are selected.

2009-04-09Don't leak marked scrollers; release them when the WKMV is deallocated.
Zachary West <zacw@adiumx.com> [Thu, 09 Apr 2009 02:11:29 +0000] rev 1617
Don't leak marked scrollers; release them when the WKMV is deallocated.

2009-04-09Fast enumerate
David Smith [Thu, 09 Apr 2009 02:01:49 +0000] rev 1616
Fast enumerate

2009-04-08As Peter pointed out, the latter and operation was broken, and 2 other things.
Zachary West <zacw@adiumx.com> [Wed, 08 Apr 2009 21:31:57 +0000] rev 1615
As Peter pointed out, the latter and operation was broken, and 2 other things.

2009-04-08Now with less memory leak.
Zachary West <zacw@adiumx.com> [Wed, 08 Apr 2009 21:11:49 +0000] rev 1614
Now with less memory leak.

2009-04-08Raw commands can contain passwords; we don't want to AILog it.
Zachary West <zacw@adiumx.com> [Wed, 08 Apr 2009 21:04:49 +0000] rev 1613
Raw commands can contain passwords; we don't want to AILog it.

2009-04-08In the shelf view, ask the delegate for a context menu, since it will largely depend on the shelf contents. It's not something that can be cached like bindings cause.
Zachary West <zacw@adiumx.com> [Wed, 08 Apr 2009 21:04:06 +0000] rev 1612
In the shelf view, ask the delegate for a context menu, since it will largely depend on the shelf contents. It's not something that can be cached like bindings cause.

Enables multiple select in the user list, and provides access to the selected list objects in AIMessageViewController.

Adds an IRC context menu with "op" (+anti), "voice" (+anti), "kick", "ban" (only does +b nick, we need to store user@hosts first), and "bankick", plus info/ignore/logs.

2009-04-08Speed up resizing the user list by delaying saving the preference until the resize is done.
Zachary West <zacw@adiumx.com> [Wed, 08 Apr 2009 20:02:20 +0000] rev 1611
Speed up resizing the user list by delaying saving the preference until the resize is done.

2009-04-08Autorelease our file handle...
David Smith [Wed, 08 Apr 2009 01:59:33 +0000] rev 1610
Autorelease our file handle...

2009-04-07As Peter suggested, rename {{{-actionsForchat:}}} to {{{-actionMenuForChat:}}} since the former implied selectorness. Removes the CBPurpleAccount empty definition.
Zachary West <zacw@adiumx.com> [Tue, 07 Apr 2009 23:57:14 +0000] rev 1609
As Peter suggested, rename {{{-actionsForchat:}}} to {{{-actionMenuForChat:}}} since the former implied selectorness. Removes the CBPurpleAccount empty definition.

2009-04-07Don't (locally) convert a link starting with "#" into a channel link. Fixes #11877.
Zachary West <zacw@adiumx.com> [Tue, 07 Apr 2009 23:52:37 +0000] rev 1608
Don't (locally) convert a link starting with "#" into a channel link. Fixes #11877.

2009-04-07Fix the position of a shelf action button when the shelf is on the left side
Zachary West <zacw@adiumx.com> [Tue, 07 Apr 2009 16:12:10 +0000] rev 1607
Fix the position of a shelf action button when the shelf is on the left side

2009-04-07Like every resize control in the world, don't resize to the point of the mouse, resize as though it was dragging the view.
Zachary West <zacw@adiumx.com> [Tue, 07 Apr 2009 05:37:09 +0000] rev 1606
Like every resize control in the world, don't resize to the point of the mouse, resize as though it was dragging the view.

2009-04-07Committing new version of PSMTabBarControl (r280). Includes a change to move the object counter over three pixels to the right. Looks much nicer this way.
Colin Barrett [Tue, 07 Apr 2009 05:18:05 +0000] rev 1605
Committing new version of PSMTabBarControl (r280). Includes a change to move the object counter over three pixels to the right. Looks much nicer this way.

2009-04-07Make the text in the shelf view draw centered.
Zachary West <zacw@adiumx.com> [Tue, 07 Apr 2009 05:16:22 +0000] rev 1604
Make the text in the shelf view draw centered.

2009-04-07Make the blue color match my precious.
Zachary West <zacw@adiumx.com> [Tue, 07 Apr 2009 05:09:56 +0000] rev 1603
Make the blue color match my precious.

2009-04-07Revert [26624], bringing back my blue precious.
Zachary West <zacw@adiumx.com> [Tue, 07 Apr 2009 05:06:53 +0000] rev 1602
Revert [26624], bringing back my blue precious.

2009-04-07Story of my life.
Zachary West <zacw@adiumx.com> [Tue, 07 Apr 2009 05:03:51 +0000] rev 1601
Story of my life.

2009-04-07Clean up the display of, and clicking of, the action button in the shelf view. Draw some more lines, and support drawing the button + text at the same time. Enable by default, but currently only IRC displays it (and the menu says "Coming Soon").
Zachary West <zacw@adiumx.com> [Tue, 07 Apr 2009 05:01:57 +0000] rev 1600
Clean up the display of, and clicking of, the action button in the shelf view. Draw some more lines, and support drawing the button + text at the same time. Enable by default, but currently only IRC displays it (and the menu says "Coming Soon").

2009-04-07Propertyize some more
David Smith [Tue, 07 Apr 2009 00:42:00 +0000] rev 1599
Propertyize some more

2009-04-07Synthesize
David Smith [Tue, 07 Apr 2009 00:32:21 +0000] rev 1598
Synthesize

2009-04-07Simplify code by setting [NSNumber numberWithBool:NO] instead of nil for properties. This should be just as memory efficient since NSNumber caches those.
David Smith [Tue, 07 Apr 2009 00:13:15 +0000] rev 1597
Simplify code by setting [NSNumber numberWithBool:NO] instead of nil for properties. This should be just as memory efficient since NSNumber caches those.

2009-04-07Assorted simplifications. No intended behavior change, yell at me if you spot one ;)
David Smith [Tue, 07 Apr 2009 00:04:38 +0000] rev 1596
Assorted simplifications. No intended behavior change, yell at me if you spot one ;)

2009-04-06Fast enumeration, some identation
David Smith [Mon, 06 Apr 2009 23:04:54 +0000] rev 1595
Fast enumeration, some identation

2009-04-06Fix an old typo
David Smith [Mon, 06 Apr 2009 22:58:19 +0000] rev 1594
Fix an old typo

2009-04-06Changelogging some more.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 21:10:30 +0000] rev 1593
Changelogging some more.

2009-04-06And changelogging something else I forgot.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 21:05:35 +0000] rev 1592
And changelogging something else I forgot.

2009-04-06Changelogging Clear Display in the Display menu.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 21:04:28 +0000] rev 1591
Changelogging Clear Display in the Display menu.

2009-04-06Changelogging user list sideage.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 21:02:27 +0000] rev 1590
Changelogging user list sideage.

2009-04-06What the heck is this header?
David Smith [Mon, 06 Apr 2009 20:44:03 +0000] rev 1589
What the heck is this header?

2009-04-06Expose the chat container -> message view controller link. Add a "Clear Display" menu item to the Display menu.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 20:36:27 +0000] rev 1588
Expose the chat container -> message view controller link. Add a "Clear Display" menu item to the Display menu.

2009-04-06Add "Toggle User List Side" to the Display menu. Unlike the user list toggle, this is a global preference change.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 20:03:35 +0000] rev 1587
Add "Toggle User List Side" to the Display menu. Unlike the user list toggle, this is a global preference change.

2009-04-06Reenable parallel targets. [26792] indicates that disabling it did not help
David Smith [Mon, 06 Apr 2009 19:55:25 +0000] rev 1586
Reenable parallel targets. [26792] indicates that disabling it did not help

2009-04-06Apparently we no longer use IconFamily. Axe it :)
David Smith [Mon, 06 Apr 2009 19:53:57 +0000] rev 1585
Apparently we no longer use IconFamily. Axe it :)

2009-04-06As usual, an NSLog slipped in.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 19:42:58 +0000] rev 1584
As usual, an NSLog slipped in.

2009-04-06Properly save the user list's width when it's modified, and modify all open chats to the new width when the preference changes.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 19:42:29 +0000] rev 1583
Properly save the user list's width when it's modified, and modify all open chats to the new width when the preference changes.

2009-04-06D'oh, forgot to save.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 19:19:34 +0000] rev 1582
D'oh, forgot to save.

2009-04-06Only validate the "Jump to…" menu items when a jump could actually occur.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 19:18:34 +0000] rev 1581
Only validate the "Jump to…" menu items when a jump could actually occur.

2009-04-06Bonjour once again failed to compile in, removing the clean requirement again.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 14:08:36 +0000] rev 1580
Bonjour once again failed to compile in, removing the clean requirement again.

2009-04-06After noticing that we only use this function in one way, provided a simpler function with the defaults.
Matt Handley [Mon, 06 Apr 2009 13:37:51 +0000] rev 1579
After noticing that we only use this function in one way, provided a simpler function with the defaults.
Oh, how I miss C++'s default params.

2009-04-06Changing svn:ignore to ignore some files I don't think we ever want checked in.
Matt Handley [Mon, 06 Apr 2009 13:32:14 +0000] rev 1578
Changing svn:ignore to ignore some files I don't think we ever want checked in.

2009-04-06Project changes for 26788
David Smith [Mon, 06 Apr 2009 09:21:34 +0000] rev 1577
Project changes for 26788

2009-04-06Fold NSString+CarbonFSRefCreation into its one client, greatly simplifying it in the process
David Smith [Mon, 06 Apr 2009 09:20:55 +0000] rev 1576
Fold NSString+CarbonFSRefCreation into its one client, greatly simplifying it in the process

2009-04-06Stop throwing exceptions when hovering people in the twitter timeline on your contact list
David Smith [Mon, 06 Apr 2009 08:35:22 +0000] rev 1575
Stop throwing exceptions when hovering people in the twitter timeline on your contact list

2009-04-06coding style
David Smith [Mon, 06 Apr 2009 08:19:10 +0000] rev 1574
coding style

2009-04-06Burninate NDRunLoopMessenger now that it is no longer needed
David Smith [Mon, 06 Apr 2009 08:16:42 +0000] rev 1573
Burninate NDRunLoopMessenger now that it is no longer needed

2009-04-06Fix crash on disconnect for bonjour
David Smith [Mon, 06 Apr 2009 08:08:22 +0000] rev 1572
Fix crash on disconnect for bonjour

2009-04-06Run bonjour on the main thread. It appears (in my testing, I tried to be thorough) to work just great aside from a pre-existing crash on disconnect (recent regression) which will hopefully be easier to track down now
David Smith [Mon, 06 Apr 2009 08:00:09 +0000] rev 1571
Run bonjour on the main thread. It appears (in my testing, I tried to be thorough) to work just great aside from a pre-existing crash on disconnect (recent regression) which will hopefully be easier to track down now

2009-04-06What I meant...
David Smith [Mon, 06 Apr 2009 05:57:50 +0000] rev 1570
What I meant...

2009-04-06An AIXMLAppendXMLOperation showed up in my leaks output, which I suspect is due to throwing away an appender and it not releasing lastOp. We really have no need for that though, so this should avoid the leak and be simpler
David Smith [Mon, 06 Apr 2009 05:49:18 +0000] rev 1569
An AIXMLAppendXMLOperation showed up in my leaks output, which I suspect is due to throwing away an appender and it not releasing lastOp. We really have no need for that though, so this should avoid the leak and be simpler

2009-04-06Don't use a trash variable to scan into, and as Peter pointed out, NULL not nil for the no-pointer specification.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 04:50:36 +0000] rev 1568
Don't use a trash variable to scan into, and as Peter pointed out, NULL not nil for the no-pointer specification.

2009-04-06Recalculate sizes on side or line status (though the latter not so much going to be happening) changes.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 04:49:39 +0000] rev 1567
Recalculate sizes on side or line status (though the latter not so much going to be happening) changes.

2009-04-06Don't draw the divider line for the message view's shelf view.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 04:35:52 +0000] rev 1566
Don't draw the divider line for the message view's shelf view.

2009-04-06Draw the user list on the right. This is swappable, so it won't be hard to make it a preference.
Zachary West <zacw@adiumx.com> [Mon, 06 Apr 2009 04:04:51 +0000] rev 1565
Draw the user list on the right. This is swappable, so it won't be hard to make it a preference.

2009-04-06Oops. Thanks Peter :)
David Smith [Mon, 06 Apr 2009 03:21:16 +0000] rev 1564
Oops. Thanks Peter :)

2009-04-06Implement a missing dealloc
David Smith [Mon, 06 Apr 2009 02:45:25 +0000] rev 1563
Implement a missing dealloc

2009-04-06Implement -dealloc for AIHTMLDecoder, fixing some leaks
David Smith [Mon, 06 Apr 2009 01:57:00 +0000] rev 1562
Implement -dealloc for AIHTMLDecoder, fixing some leaks

2009-04-06Stop leaking all our date format strings
David Smith [Mon, 06 Apr 2009 00:47:16 +0000] rev 1561
Stop leaking all our date format strings

2009-04-05Set the menu title for Display menu so it shows up before the Menu Controller loads.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 22:44:32 +0000] rev 1560
Set the menu title for Display menu so it shows up before the Menu Controller loads.

2009-04-05Project changes for [26770].
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 22:44:16 +0000] rev 1559
Project changes for [26770].

2009-04-05Rename AIOfflineContactHidingPlugin to AIContactVisibilityControlPlugin.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 22:42:19 +0000] rev 1558
Rename AIOfflineContactHidingPlugin to AIContactVisibilityControlPlugin.

2009-04-05Enable "Show Unread Message Count in Tabs" by default.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 20:49:37 +0000] rev 1557
Enable "Show Unread Message Count in Tabs" by default.

2009-04-05Reinstate the clean requirement on the Nightly since nonparallel targets might fix it.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 20:37:19 +0000] rev 1556
Reinstate the clean requirement on the Nightly since nonparallel targets might fix it.

2009-04-05Correct JVMarkedScroller's behavior when it tries to scroll to a mark which doesn't trigger the knob to move, such as when the knob is all the way at the bottom. Since it wouldn't need to redraw, it doesn't, so the previousMark never gets updated (so it never updates to go to the previous one).
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 20:22:15 +0000] rev 1555
Correct JVMarkedScroller's behavior when it tries to scroll to a mark which doesn't trigger the knob to move, such as when the knob is all the way at the bottom. Since it wouldn't need to redraw, it doesn't, so the previousMark never gets updated (so it never updates to go to the previous one).

2009-04-05Disable build targets in parallel. This may fix our persistent build issues
David Smith [Sun, 05 Apr 2009 20:12:55 +0000] rev 1554
Disable build targets in parallel. This may fix our persistent build issues

2009-04-05Redisplaying didn't actually fix it. The problem is in JVMarkedScroller (shomehow), will have to fix it there. I think the WebView's scroll view isn't correctly moving up—sending the {{{scrollPoint:}}} to the correct location doesn't actually move to that point.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 18:53:14 +0000] rev 1553
Redisplaying didn't actually fix it. The problem is in JVMarkedScroller (shomehow), will have to fix it there. I think the WebView's scroll view isn't correctly moving up—sending the {{{scrollPoint:}}} to the correct location doesn't actually move to that point.

2009-04-05Remove all marks when clearing the display. Redisplay the shelf view when a tab item is selected, which fixes the "jump to previous…" not working on initial selection.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 18:39:55 +0000] rev 1552
Remove all marks when clearing the display. Redisplay the shelf view when a tab item is selected, which fixes the "jump to previous…" not working on initial selection.

2009-04-05Err, off by 1 indentation level for that part. Refs #11813.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 17:34:36 +0000] rev 1551
Err, off by 1 indentation level for that part. Refs #11813.

2009-04-05My best guess as to why this crash is happening is that we're incrementing the usage count unsynchronized and causing a race condition (yielding 1 less than we actually want) which is causing the cache to get wiped out. If this crash still occurs (I removed the return; which was preventing it from crashing) please reopen. Fixes #11813.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 17:32:40 +0000] rev 1550
My best guess as to why this crash is happening is that we're incrementing the usage count unsynchronized and causing a race condition (yielding 1 less than we actually want) which is causing the cache to get wiped out. If this crash still occurs (I removed the return; which was preventing it from crashing) please reopen. Fixes #11813.

2009-04-05Make the nightly not do a clean build, so I can actually get one with Bonjour working.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 15:43:35 +0000] rev 1549
Make the nightly not do a clean build, so I can actually get one with Bonjour working.

2009-04-05Evidently I'm absolutely terrible at responder chains. Setting the next responder to the user list causes a loop-around effect which, in the end, causes the user list to scroll when the message view scrolls. Setting it to the overall view somehow fixes this AND the hover issue I was seeing earlier. If this doesn't completely work I'm calling an exorcist.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 06:07:08 +0000] rev 1548
Evidently I'm absolutely terrible at responder chains. Setting the next responder to the user list causes a loop-around effect which, in the end, causes the user list to scroll when the message view scrolls. Setting it to the overall view somehow fixes this AND the hover issue I was seeing earlier. If this doesn't completely work I'm calling an exorcist.

2009-04-05Changeloggificationization.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 05:04:12 +0000] rev 1547
Changeloggificationization.

2009-04-05Setting the next responder to nil breaks the hovering in the message view; set it to the user list (hey, anything but itself is a good thing). Refs #11856.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 04:42:31 +0000] rev 1546
Setting the next responder to nil breaks the hovering in the message view; set it to the user list (hey, anything but itself is a good thing). Refs #11856.

2009-04-05Move JVMarkedScroller into a group in AIUtilities.
Zachary West <zacw@adiumx.com> [Sun, 05 Apr 2009 04:17:49 +0000] rev 1545
Move JVMarkedScroller into a group in AIUtilities.

2009-04-05This builds libpurple with the -vv dependencies successfully. However, the frameworks are not produced yet... I'm not sure what to do in terms of universalizing and frameworking the gstreamer ("gst") plugins (it'll almost certainly also require a source patch to gstreamer to change how it looks up its plugin directory). Help or thoughts appreciated!
Evan Schoenberg [Sun, 05 Apr 2009 03:55:07 +0000] rev 1544
This builds libpurple with the -vv dependencies successfully. However, the frameworks are not produced yet... I'm not sure what to do in terms of universalizing and frameworking the gstreamer ("gst") plugins (it'll almost certainly also require a source patch to gstreamer to change how it looks up its plugin directory). Help or thoughts appreciated!